Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more lenient when there are multiple merge bases #9

Open
jjlharrison opened this issue Nov 11, 2021 · 0 comments
Open

Be more lenient when there are multiple merge bases #9

jjlharrison opened this issue Nov 11, 2021 · 0 comments

Comments

@jjlharrison
Copy link
Owner

Background

There can be multiple merge bases with a given branch. This can mean that you can find yourself in the situation where the coverage plugin selects a merge base that does not include changes that were introduced later in that same branch. Example;

  1. Branch off develop and make changes.
  2. Take an earlier branch from develop (a hotfix for example) and merge it into your new branch.

If the merge base is selected from the earlier hotfix you may find that the coverage plugin wants you to write coverage for changes in develop. This may be implausible.

Solution

Do not select a single merge base. Collect all of them, check the diffs and coverage for each, and then use the most lenient for enforcing coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant