session.groups is not defined in toPlanB() & toUnifiedPlan()

[marcofanch]

Hi, thanks for providing the polyfill for the inter-browser RTC.

I just discovered this package today, and gave it a try.
I found that the library will throw an error inside toPlanB() and toUnifiedPlan() while the call in connecting.
Giving a simple check before accessing session.groups is not working, another error will come out.

My guess is that the library was not maintained and thus those conversions have became outdated.
(Chrome 49 and Firefox 45 were used)
We have to update the parsing function in order to get it work.

Is my guess correct?
If so, would it be possible to update those features? Or could you point out where we can find the document to fix them ourself?

Many thanks.

[gpolitis]

Hi @marcofanch, could you please provide the failing SDP so that I can have a look? Thank you.

On Apr 14, 2016, at 8:25 AM, marcofanch [email protected] wrote:

Hi, thanks for providing the polyfill for the inter-browser RTC.

I just discovered this package today, and gave it a try.
I found that the library will throw an error inside toPlanB() and toUnifiedPlan() while the call in connecting.
Giving a simple check before accessing session.groups is not working, another error will come out.

My guess is that the library was not maintained and thus those conversions have became outdated.
(Chrome 49 and Firefox 45 were used)
We have to update the parsing function in order to get it work.

Is my guess correct?
If so, would it be possible to update those features? Or could you point out where we can find the document to fix them ourself?

Many thanks.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #21

[marcofanch]

@gpolitis, thanks for looking into it.

This is captured in Chrome, for that Firefox is replying the INVITE.

v=0
o=mozilla...THIS_IS_SDPARTA-45.0.2 652859640 681015753 IN IP4 202.94.87.21
s=-
t=0 0
a=sendrecv
a=ice-lite
m=audio 6295 RTP/SAVPF 109 9 0 8 101
c=IN IP4 202.94.87.21
a=sendrecv
a=end-of-candidates
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=msid:{c6cff894-6008-514b-96e2-8667c56bb54a} {7ad371d8-6b94-3847-8884-82af02aaef72}
a=rtpmap:109 opus/48000/2
a=rtpmap:9 G722/8000/1
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=fingerprint:sha-256 33:FC:86:1A:58:24:4B:7B:8D:37:24:24:59:13:02:3C:C7:A5:78:1E:2A:3A:C1:3E:DC:95:53:98:F3:44:69:A9
a=setup:active
a=ice-ufrag:LyQcOdaS3Hkus5s9
a=ice-pwd:ZpBkylZpjuixD+ZXKWdUCtCh
a=candidate:670853707 1 udp 2130706431 202.94.87.21 6295 typ host
a=rtcp-mux

While accessing the setRemoteDescription() in the adapter, interop.toPlanB() throws TypeError: Cannot read property 'some' of undefined.

        session.groups.some(function(group) {
            if (group.type === 'BUNDLE') {
                group.mids = types.join(' ');
                return true;
            }
        });

[gpolitis]

Since there’s only one m-line in the SDP, there’s nothing to group. I can provide a fix for that in a branch, but I don’t have the time to test it. Would you feel comfortable building and using the polyfill from source?

On Apr 14, 2016, at 9:47 PM, marcofanch [email protected] wrote:

@gpolitis https://github.com/gpolitis, thanks for looking into it.

This is captured in Chrome, for that Firefox is replying the INVITE.

v=0
o=mozilla...THIS_IS_SDPARTA-45.0.2 652859640 681015753 IN IP4 202.94.87.21
s=-
t=0 0
a=sendrecv
a=ice-lite
m=audio 6295 RTP/SAVPF 109 9 0 8 101
c=IN IP4 202.94.87.21
a=sendrecv
a=end-of-candidates
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=msid:{c6cff894-6008-514b-96e2-8667c56bb54a} {7ad371d8-6b94-3847-8884-82af02aaef72}
a=rtpmap:109 opus/48000/2
a=rtpmap:9 G722/8000/1
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=fingerprint:sha-256 33:FC:86:1A:58:24:4B:7B:8D:37:24:24:59:13:02:3C:C7:A5:78:1E:2A:3A:C1:3E:DC:95:53:98:F3:44:69:A9
a=setup:active
a=ice-ufrag:LyQcOdaS3Hkus5s9
a=ice-pwd:ZpBkylZpjuixD+ZXKWdUCtCh
a=candidate:670853707 1 udp 2130706431 202.94.87.21 6295 typ host
a=rtcp-mux
While accessing the setRemoteDescription() in the adapter, interop.toPlanB() throws TypeError: Cannot read property 'some' of undefined.

    session.groups.some(function(group) {
        if (group.type === 'BUNDLE') {
            group.mids = types.join(' ');
            return true;
        }
    });

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #21 (comment)

[marcofanch]

Thanks @gpolitis, we can try it :)

[TheDanielMoli]

I'm facing the same issue, what should I do?

[iclems]

@gpolitis would you mind sharing that fix?