Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jim is away for a week =) #813

Closed
jimsalterjrs opened this issue Apr 7, 2023 · 13 comments
Closed

Jim is away for a week =) #813

jimsalterjrs opened this issue Apr 7, 2023 · 13 comments

Comments

@jimsalterjrs
Copy link
Owner

Hi contributors and other folks!

We're pretty overdue for a great big merge party soon, but I'll be out of town for the next week (8th-15th). Anybody who's got a PR in (and @phreaker0 ), can we maybe set up a merge day sometime the week of the 16th-23rd? We'll want PR authors on hand to rebase patches as needed; sometimes accepting one PR invalidates another until rebase.

Thanks!

@phreaker0
Copy link
Collaborator

hi @jimsalterjrs, the following PR are reviewed/tested and can be merged right away if you like:

#523
#622
#808
#809

@phreaker0
Copy link
Collaborator

should be safe too: #746

@HankB
Copy link

HankB commented Apr 25, 2023

If one of these PRs involves the Usage: produced when sanoid -? is executed, can the defaults be updated?

    Assumes --cron --verbose if no other arguments (other than configdir)
    are specified

I just put 2.1.0 on a new machine and confirm that sudo sanoid creates no snapshots (or output) whereas sudo sanoid --cron does.

Should I submit a PR?

Thanks!

@jimsalterjrs
Copy link
Owner Author

#809 and #622 need to be rebased. The others merged okay. Haven't done any testing yet.

@phreaker0
Copy link
Collaborator

@jimsalterjrs rebased #809, will rebase #622 after merge of the former because this will trigger an conflict.

@jimsalterjrs
Copy link
Owner Author

@phreaker0 #809 merged.

@phreaker0
Copy link
Collaborator

@HankB i looked into it and you are right, this is a regression. I created a PR which only changes a single digit :-D #819 thank you

@phreaker0
Copy link
Collaborator

@jimsalterjrs thanks, I rebased #622

@jimsalterjrs
Copy link
Owner Author

#622 Merged.

@sarcasticadmin
Copy link

Thank you for merging all of these PRs @phreaker0 @jimsalterjrs

Will there be an upcoming tag cut as well?

@msladek
Copy link

msladek commented May 17, 2023

#625 has also just been rebased by @0xFelix the author. any chance of a merge @phreaker0 ?
without it sanoid still can't replicate from bookmarks (if there are newer common snapshots).

@pgassmann
Copy link

@jimsalterjrs are you also planning to create a new release? the last one on github was 2 years ago, on April 1, 2021.
We are hitting a bug that was fixed more than a year ago. #734
How safe is it to use the script from the master branch?

@jimsalterjrs
Copy link
Owner Author

How safe is it to use the script from the master branch?

Generally speaking, tends to be safe as kittens. @phreaker0 and I are the only ones with commit/merge privileges, and we have the explicit goal of keeping master as safe as we can between releases. Occasionally, one of us has merged a PR with a bug we didn't catch first... But I explicitly do all of my (pretty frequent) personal sanoid installations from master, so I generally catch any significant bugs in master pretty quickly when they appear.

Btw, we released v2.2.0 today. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants