Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more specifict extension name than properites #21

Open
ghost opened this issue Jul 12, 2018 · 1 comment
Open

Use more specifict extension name than properites #21

ghost opened this issue Jul 12, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 12, 2018

The de.jgoldhammer.alfresco.jscript.variables.ScriptVariablesService is registered as a JavaScript extension using the name properties. This name is somewhat unspecific.

I suggest to change the extensionName to something more specific like alfrescoGlobalProperties.
hi-ko added a commit to ecm4u/alfresco-jscript-extensions that referenced this issue Jul 13, 2018
@hi-ko
fix jgoldhammer#21 to avoid name clashes with node properties
9e84a8e 
s. jgoldhammer#21
@jgoldhammer
Copy link
Owner

Can you add a PR for this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgoldhammer