From 707b2f14f81c881925e1c9285bdea8658fffba4d Mon Sep 17 00:00:00 2001 From: Flo Edelmann Date: Tue, 3 Dec 2024 21:35:58 +0100 Subject: [PATCH] fix: remove `no-alias-methods` from `style` config --- README.md | 2 +- docs/rules/no-alias-methods.md | 4 +--- src/__tests__/__snapshots__/rules.test.ts.snap | 2 -- src/index.ts | 1 - 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index d6fde7605..c0a1e7354 100644 --- a/README.md +++ b/README.md @@ -329,7 +329,7 @@ Manually fixable by | [expect-expect](docs/rules/expect-expect.md) | Enforce assertion to be made in a test body | | ✅ | | | | [max-expects](docs/rules/max-expects.md) | Enforces a maximum number assertion calls in a test body | | | | | | [max-nested-describe](docs/rules/max-nested-describe.md) | Enforces a maximum depth to nested describe calls | | | | | -| [no-alias-methods](docs/rules/no-alias-methods.md) | Disallow alias methods | ✅ | 🎨 | 🔧 | | +| [no-alias-methods](docs/rules/no-alias-methods.md) | Disallow alias methods | ✅ | | 🔧 | | | [no-commented-out-tests](docs/rules/no-commented-out-tests.md) | Disallow commented out tests | | ✅ | | | | [no-conditional-expect](docs/rules/no-conditional-expect.md) | Disallow calling `expect` conditionally | ✅ | | | | | [no-conditional-in-test](docs/rules/no-conditional-in-test.md) | Disallow conditional logic in tests | | | | | diff --git a/docs/rules/no-alias-methods.md b/docs/rules/no-alias-methods.md index d69777b76..e61d13d2f 100644 --- a/docs/rules/no-alias-methods.md +++ b/docs/rules/no-alias-methods.md @@ -1,8 +1,6 @@ # Disallow alias methods (`no-alias-methods`) -💼⚠️ This rule is enabled in the ✅ `recommended` -[config](https://github.com/jest-community/eslint-plugin-jest/blob/main/README.md#shareable-configurations). -This rule _warns_ in the 🎨 `style` +💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/jest-community/eslint-plugin-jest/blob/main/README.md#shareable-configurations). 🔧 This rule is automatically fixable by the diff --git a/src/__tests__/__snapshots__/rules.test.ts.snap b/src/__tests__/__snapshots__/rules.test.ts.snap index d27e91fcb..ca9509933 100644 --- a/src/__tests__/__snapshots__/rules.test.ts.snap +++ b/src/__tests__/__snapshots__/rules.test.ts.snap @@ -240,7 +240,6 @@ exports[`rules should export configs that refer to actual rules 1`] = ` }, }, "rules": { - "jest/no-alias-methods": "warn", "jest/prefer-to-be": "error", "jest/prefer-to-contain": "error", "jest/prefer-to-have-length": "error", @@ -283,7 +282,6 @@ exports[`rules should export configs that refer to actual rules 1`] = ` "jest", ], "rules": { - "jest/no-alias-methods": "warn", "jest/prefer-to-be": "error", "jest/prefer-to-contain": "error", "jest/prefer-to-have-length": "error", diff --git a/src/index.ts b/src/index.ts index d6322697a..10cd1b3a9 100644 --- a/src/index.ts +++ b/src/index.ts @@ -53,7 +53,6 @@ const recommendedRules = { } satisfies Record; const styleRules = { - 'jest/no-alias-methods': 'warn', 'jest/prefer-to-be': 'error', 'jest/prefer-to-contain': 'error', 'jest/prefer-to-have-length': 'error',