Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #61

Closed
gforcada opened this issue May 26, 2015 · 9 comments
Closed

New release? #61

gforcada opened this issue May 26, 2015 · 9 comments

Comments

@gforcada
Copy link

@mfriedenhagen I see that you made quite a few merges on this plugin, would it be possible to also make a release so that those fixes get into our jenkins servers?

If not, is there any instructions around to build and deploy jenkins plugins (for java newbies)?

@mfriedenhagen
Copy link
Member

Hello Gil, I did develop some things in a branch, but they did not work out
properly for Maven 2 jobs. We now do use SonarQube for QA metrics instead
and did remove the violations plugin completely from our Jenkins
infrastructure.

Regards Mirko

http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)
https://bitbucket.org/mfriedenhagen/

On Tue, May 26, 2015 at 6:09 PM, Gil Forcada Codinachs <
[email protected]> wrote:

@mfriedenhagen https://github.com/mfriedenhagen I see that you made
quite a few merges on this plugin, would it be possible to also make a
release so that those fixes get into our jenkins servers?

If not, is there any instructions around to build and deploy jenkins
plugins (for java newbies)?


Reply to this email directly or view it on GitHub
#61.

@tomasbjerre
Copy link
Contributor

I sent an email to till @peterkittreilly on the subject.

I just found out that you can release experimental versions of plugins:
"If you are developing plugins and you want to distribute experimental plugins, all you have to do is to put 'alpha' or 'beta' in the version number of pom.xml. The backend infrastructure takes care of the rest." - http://jenkins-ci.org/content/experimental-plugins-update-center

Would be nice if we could come up with a roadmap for a version 0.8 release. How about this?

  • Go through the PR:s and merge, close or at least give some constuctive feedback on all of them
  • Go through the issues, close as many as possible
  • Clean the code. Add LICENSE, README.md, a coding standard, format the code according to that standard. Cleanup pom.xml, it is missing release-plugin, surefire, description-tag and license, issueManagement points to JIRA and scm is missing url and tag...
  • Make an experimental release
  • Test the code. Go throgh the code and add test cases. Unit tests primarily but maby also some use cases with Webdriver.
  • Make a second experimental release.
  • After a couple of months without any major issues: release 0.8!

@gforcada
Copy link
Author

gforcada commented Jun 2, 2015

@tomasbjerre sounds really cool to me, I would actually do a first experimental release right away, so that we can already test if what's already in is working or not.

Unfortunately I don't have much time nor knowledge to help on this, but I have some time to test the releases

@tomasbjerre tomasbjerre mentioned this issue Jun 7, 2015
@tomasbjerre
Copy link
Contributor

What do you think about #62 ? I would like to merge it and then start writing test cases and cleaning the code.

@mfriedenhagen
Copy link
Member

The killer for this plugin was JENKINS-24506. There is still a branch here where I tried to fix it but did not succeed. So setting a build to unstable or failed is not possible with Maven2 jobs.

@mfriedenhagen
Copy link
Member

The killer for this plugin was JENKINS-24506. There is still a branch here where I tried to fix it but did not succeed. So setting a build to unstable or failed is not possible with Maven2 jobs.

The other PR #6 is very, very old. I did not merge it because I used it in a private vendor version and forgot about it

@tomasbjerre
Copy link
Contributor

You mean #4 not #6 right?
Can we close #6? It looks like the most important change (0a15a05) is already fixed in 388c8080 .

Would also be nice to have your opinion on my suggested approach for a new release.

@tomasbjerre
Copy link
Contributor

Sorry for spamming =) I was testing commits in Travis CI, so was pushing alot... should probably avoid having the issue in the comment next time.

@tomasbjerre
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants