From 0f18f4ca2039b2471b39c36ac64798c60e9d7dee Mon Sep 17 00:00:00 2001 From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com> Date: Fri, 1 Nov 2024 15:26:25 -0400 Subject: [PATCH 1/2] remove legacy checkUrls --- .../org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly b/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly index cbb7a47..7f2726d 100644 --- a/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly +++ b/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly @@ -7,14 +7,14 @@ <f:repeatable var="site" name="sites" items="${descriptor.sites}"> <table width="100%"> <f:entry title="${%Hostname}" help="/plugin/ssh/help-hostname.html"> - <f:textbox name="hostname" value="${site.hostname}" checkUrl="'${rootURL}/descriptorByName/org.jvnet.hudson.plugins.SSHBuildWrapper/checkHostname?hostname='+escape(this.value)" /> + <f:textbox name="hostname" value="${site.hostname}" field="hostname" /> </f:entry> <f:entry title="${%Port}" help="/plugin/ssh/help-port.html"> <f:textbox name="port" value="${site.port}"/> </f:entry> <f:entry title="${%Credentials}"> - <c:select name="credentialId" field="credentialId" value="${site.credentialId}" checkUrl="'${rootURL}/descriptorByName/org.jvnet.hudson.plugins.SSHBuildWrapper/checkCredentialId?credentialId='+escape(this.value)" /> + <c:select name="credentialId" field="credentialId" value="${site.credentialId}" /> </f:entry> <f:entry title="${%Pty}" help="/plugin/ssh/help-pty.html"> From 4729b5a8450deaf8e81d68a7021ed94db7785c81 Mon Sep 17 00:00:00 2001 From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com> Date: Fri, 8 Nov 2024 13:14:58 -0500 Subject: [PATCH 2/2] simplify entries --- .../org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly b/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly index 7f2726d..9a58919 100644 --- a/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly +++ b/src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly @@ -6,15 +6,15 @@ description="${%SSH sites that projects will want to connect}"> <f:repeatable var="site" name="sites" items="${descriptor.sites}"> <table width="100%"> - <f:entry title="${%Hostname}" help="/plugin/ssh/help-hostname.html"> - <f:textbox name="hostname" value="${site.hostname}" field="hostname" /> + <f:entry title="${%Hostname}" field="hostname" help="/plugin/ssh/help-hostname.html"> + <f:textbox/> </f:entry> <f:entry title="${%Port}" help="/plugin/ssh/help-port.html"> <f:textbox name="port" value="${site.port}"/> </f:entry> - <f:entry title="${%Credentials}"> - <c:select name="credentialId" field="credentialId" value="${site.credentialId}" /> + <f:entry title="${%Credentials}" field="credentialId"> + <c:select/> </f:entry> <f:entry title="${%Pty}" help="/plugin/ssh/help-pty.html">