From cae313a90e627e04c715db7e1c6f5786acd32eac Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Sat, 4 Jan 2025 19:06:41 -0700
Subject: [PATCH] Use recommended format for scm connection fields (#153)

* Use recommended format for scm connection fields

Silences a Maven warning

* Enable incrementals for easier testing and development

https://www.jenkins.io/doc/developer/tutorial-improve/enable-incrementals/
describes the steps taken in the commit.

https://www.jenkins.io/doc/developer/plugin-development/incrementals/
provides more details of the benefits of incrementals and the way that
they help users and developers.

* Remove developers list

Official list of developers is stored in the repository permissions
updater.
---
 .mvn/extensions.xml |  7 +++++++
 .mvn/maven.config   |  2 ++
 pom.xml             | 29 ++++++++---------------------
 3 files changed, 17 insertions(+), 21 deletions(-)
 create mode 100644 .mvn/extensions.xml
 create mode 100644 .mvn/maven.config

diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml
new file mode 100644
index 0000000..4e0774d
--- /dev/null
+++ b/.mvn/extensions.xml
@@ -0,0 +1,7 @@
+<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">
+  <extension>
+    <groupId>io.jenkins.tools.incrementals</groupId>
+    <artifactId>git-changelist-maven-extension</artifactId>
+    <version>1.8</version>
+  </extension>
+</extensions>
diff --git a/.mvn/maven.config b/.mvn/maven.config
new file mode 100644
index 0000000..2a0299c
--- /dev/null
+++ b/.mvn/maven.config
@@ -0,0 +1,2 @@
+-Pconsume-incrementals
+-Pmight-produce-incrementals
diff --git a/pom.xml b/pom.xml
index 6be94d9..b63f5f9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -9,6 +9,9 @@
   </parent>
 
   <properties>
+    <revision>2.2.1</revision>
+    <changelist>-SNAPSHOT</changelist>
+    <gitHubRepo>jenkinsci/plot-plugin</gitHubRepo>
     <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
     <jenkins.baseline>2.452</jenkins.baseline>
     <jenkins.version>${jenkins.baseline}.4</jenkins.version>
@@ -37,25 +40,9 @@
   <artifactId>plot</artifactId>
   <packaging>hpi</packaging>
   <name>Plot plugin</name>
-  <version>2.2.1-SNAPSHOT</version>
+  <version>${revision}${changelist}</version>
   <url>https://github.com/jenkinsci/plot-plugin</url>
 
-  <developers>
-    <developer>
-      <id>nidaley</id>
-      <name>Nigel Daley</name>
-    </developer>
-    <developer>
-      <id>ericbn</id>
-      <name>Eric Nielsen</name>
-    </developer>
-    <developer>
-      <id>vgaidarji</id>
-      <name>Veaceslav Gaidarji</name>
-      <email>veaceslav.gaidarji@gmail.com</email>
-    </developer>
-  </developers>
-
   <dependencies>
     <dependency>
       <groupId>commons-beanutils</groupId>
@@ -157,10 +144,10 @@
   </pluginRepositories>
 
   <scm>
-    <connection>scm:git:ssh://github.com/jenkinsci/plot-plugin.git</connection>
-    <developerConnection>scm:git:ssh://git@github.com/jenkinsci/plot-plugin.git</developerConnection>
-    <url>https://github.com/jenkinsci/plot-plugin</url>
-    <tag>HEAD</tag>
+    <connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
+    <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
+    <url>https://github.com/${gitHubRepo}</url>
+    <tag>${scmTag}</tag>
   </scm>
   
 </project>