From be5f6331341b2260c22064ff45cbbaf681804a5a Mon Sep 17 00:00:00 2001 From: Skisocks Date: Tue, 31 Oct 2023 14:26:31 +0000 Subject: [PATCH] test: remove baseSHA test as now returned by graphql --- pkg/keeper/keeper_test.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/keeper/keeper_test.go b/pkg/keeper/keeper_test.go index d08e46d6b..ea9087f17 100644 --- a/pkg/keeper/keeper_test.go +++ b/pkg/keeper/keeper_test.go @@ -754,18 +754,17 @@ func TestDividePool(t *testing.T) { baseSHA: "123", }, } - fc := &fgc{ - refs: map[string]string{"k/t-i heads/master": "123"}, - } + fc := &fgc{} c := &DefaultController{ spc: fc, logger: logrus.WithField("component", "keeper"), } pulls := make(map[string]PullRequest) - for _, p := range testPulls { + for idx, p := range testPulls { npr := PullRequest{Number: githubql.Int(p.number)} npr.BaseRef.Name = githubql.String(p.branch) npr.BaseRef.Prefix = "refs/heads/" + npr.BaseRefOID = githubql.String(testPJs[idx].baseSHA) npr.Repository.Name = githubql.String(p.repo) npr.Repository.Owner.Login = githubql.String(p.org) npr.Repository.URL = githubql.String(fmt.Sprintf("https://github.com/%s/%s.git", p.org, p.repo)) @@ -794,10 +793,6 @@ func TestDividePool(t *testing.T) { } for _, sp := range sps { name := fmt.Sprintf("%s/%s %s", sp.org, sp.repo, sp.branch) - sha := fc.refs[sp.org+"/"+sp.repo+" heads/"+sp.branch] - if sp.sha != sha { - t.Errorf("For subpool %s, got sha %s, expected %s.", name, sp.sha, sha) - } if len(sp.prs) == 0 { t.Errorf("Subpool %s has no PRs.", name) }