`mise use --env env ...` will create a new `mise.env.toml` file even if `.mise.env.toml` already exists #4210

sgtsquiggs · 2025-01-24T20:26:34Z

sgtsquiggs
Jan 24, 2025

Reproduce:

~ 
❯ mise use --env local uv@system
mise ~/mise.local.toml tools: uv@system

~ 
❯ mv mise.local.toml .mise.local.toml

~ 
❯ mise use --env local node@system
mise ~/mise.local.toml tools: node@system

doctor:

version: 2025.1.14 macos-arm64 (daa75da 2025-01-24)
activated: yes
shims_on_path: no

build_info:
  Target: aarch64-apple-darwin
  Features: DEFAULT, NATIVE_TLS, OPENSSL
  Built: Fri, 24 Jan 2025 17:08:10 +0000
  Rust Version: rustc 1.84.0 (9fc6b4312 2025-01-07)
  Profile: release

shell:
  /opt/homebrew/bin/fish
  fish, version 3.7.1

dirs:
  cache: ~/Library/Caches/mise
  config: ~/.config/mise
  data: ~/.local/share/mise
  shims: ~/.local/share/mise/shims
  state: ~/.local/state/mise

config_files:
  ~/.config/mise/config.toml

ignored_config_files: (none)

backends:
  aqua
  asdf
  cargo
  core
  dotnet
  gem
  go
  npm
  pipx
  spm
  ubi
  vfox

plugins:
  antlr4         ssh://[email protected]/thedavemarshall/asdf-antlr4.git#865823b
  awscli         ssh://[email protected]/MetricMike/asdf-awscli.git#c26bbb4
  buf            ssh://[email protected]/truepay/asdf-buf.git#6c27312
  direnv         ssh://[email protected]/asdf-community/asdf-direnv.git#951acd3
  golangci-lint  ssh://[email protected]/hypnoglow/asdf-golangci-lint.git#29fbe51
  hadolint       ssh://[email protected]/devlincashman/asdf-hadolint.git#335e230
  helm           ssh://[email protected]/Antiarchitect/asdf-helm.git#085651c
  helmfile       ssh://[email protected]/feniix/asdf-helmfile.git#818feac
  jq             ssh://[email protected]/lsanwick/asdf-jq.git#addae51
  just           ssh://[email protected]/olofvndrhr/asdf-just.git#3f907ee
  k9s            ssh://[email protected]/looztra/asdf-k9s.git#2b3af87
  kubectl        ssh://[email protected]/asdf-community/asdf-kubectl.git#2fb3b57
  pipx           ssh://[email protected]/yozachar/asdf-pipx.git#81cb547
  pnpm           ssh://[email protected]/jonathanmorley/asdf-pnpm.git#85221d3
  poetry         ssh://[email protected]/mise-plugins/mise-poetry.git#80d807b
  pre-commit     ssh://[email protected]/jonathanmorley/asdf-pre-commit.git#26bfc42
  protoc         ssh://[email protected]/paxosglobal/asdf-protoc.git#a44c5cd
  rust           ssh://[email protected]/code-lever/asdf-rust.git#95acf4f
  snyk           ssh://[email protected]/nirfuchs/asdf-snyk.git#a1357fc
  terraform      ssh://[email protected]/asdf-community/asdf-hashicorp.git#22eb1c4
  terragrunt     ssh://[email protected]/ohmer/asdf-terragrunt.git#29f2935
  tilt           ssh://[email protected]/eaceaser/asdf-tilt.git#69eac7b
  usage          ssh://[email protected]/jdx/mise-usage.git#fe3888a
  uv             ssh://[email protected]/asdf-community/asdf-uv.git#ce093c3
  yarn           ssh://[email protected]/twuni/asdf-yarn.git#376c540
  yq             ssh://[email protected]/sudermanjr/asdf-yq.git#772992f

toolset:
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  asdf:[email protected]
  core:[email protected]
  core:[email protected]
  core:[email protected]
  core:[email protected]
  go:google.golang.org/protobuf/cmd/[email protected]
  https://github.com/gozer/[email protected]
  https://github.com/nklmilojevic/[email protected]

path:
  ~/.local/share/mise/installs/go/1.21.13/bin
  ~/.local/share/mise/installs/python/3.10.15/bin
  ~/.local/share/mise/installs/node/18.20.4/bin
  ~/.local/share/mise/installs/buf/1.45.0/bin
  ~/.local/share/mise/installs/golangci-lint/1.54.2/bin
  ~/.local/share/mise/installs/java/corretto-17.0.13.11.1/bin
  ~/.local/share/mise/installs/just/1.25.2/bin
  ~/.local/share/mise/installs/kubectl/1.28.1/bin
  ~/.local/share/mise/installs/kubefwd/1.22.4/bin
  ~/.local/share/mise/installs/pnpm/8.15.9/bin
  ~/.local/share/mise/installs/pre-commit/2.21.0/bin
  ~/.local/share/mise/installs/rust/1.69.0/bin
  ~/.local/share/mise/installs/tilt/0.33.1/bin
  ~/.local/share/mise/installs/direnv/2.35.0/bin
  ~/.local/share/mise/installs/yq/4.44.3/bin
  ~/.local/share/mise/installs/pipx/1.7.1/bin
  ~/.local/share/mise/installs/usage/0.11.0/bin
  ~/.local/share/mise/installs/helmfile/0.164.0/bin
  ~/.local/share/mise/installs/helm/3.16.2/bin
  ~/.local/share/mise/installs/snyk/1.1260.0/bin
  ~/.local/share/mise/installs/k9s/0.32.5/bin
  ~/.local/share/mise/installs/teleport/16.4.2/
  ~/.local/share/mise/installs/awscli/2.18.15/bin
  ~/.local/share/mise/installs/protoc/28.3/bin
  ~/.local/share/mise/installs/go-google-golang-org-protobuf-cmd-protoc-gen-go/1.28.1/bin
  ~/Library/pnpm
  ~/.local/bin
  ~/go/bin
  ~/.rd/bin
  /opt/homebrew/sbin
  /opt/homebrew/opt/openssl@3/bin
  /opt/homebrew/bin
  ~/.dotfiles.fish/bin
  ~/.bin
  /usr/local/sbin
  ~/.cargo/bin
  /usr/local/bin
  /System/Cryptexes/App/usr/bin
  /usr/bin
  /bin
  /usr/sbin
  /sbin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
  /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
  /Applications/kitty.app/Contents/MacOS

env_vars:
  MISE_SHELL=fish

settings:
  asdf_compat                            true             ~/.config/mise/config.toml
  disable_hints                          ["python_multi"] ~/.config/mise/config.toml
  experimental                           true             ~/.config/mise/config.toml
  jobs                                   4                ~/.config/mise/config.toml
  plugin_autoupdate_last_check_duration  "1 week"         ~/.config/mise/config.toml
  trusted_config_paths                   ["~/fleet"]      ~/.config/mise/config.toml

1 warning found:

1. plugin rust overrides a core plugin

No problems found

sgtsquiggs · 2025-01-27T19:47:15Z

sgtsquiggs
Jan 27, 2025
Author

This seems like a simple test case to be written and validated on

0 replies

betaboon · 2025-01-27T20:55:06Z

betaboon
Jan 27, 2025

bisecting pointed me towards 8f31a33#diff-e72bf1e82a503ec391103eaae7f25e7329430d3f558c1e73f2bebfd3d2097e00L188-R189

this might be a sufficient fix

diff --git a/src/cli/use.rs b/src/cli/use.rs
index 6cce6a30..bf0530c6 100644
--- a/src/cli/use.rs
+++ b/src/cli/use.rs
@@ -185,9 +185,7 @@ impl Use {
 
     fn get_config_file(&self) -> Result<Box<dyn ConfigFile>> {
         let cwd = env::current_dir()?;
-        let path = if let Some(env) = &*env::MISE_ENV {
-            config_file_from_dir(&cwd.join(format!("mise.{env}.toml")))
-        } else if self.global || env::in_home_dir() {
+        let path = if self.global || env::in_home_dir() {
             MISE_GLOBAL_CONFIG_FILE.clone()
         } else if let Some(env) = &self.env {
             let p = cwd.join(format!(".mise.{env}.toml"));

1 reply

roele Jan 28, 2025

already have a PR in place which also fixes #4211. IMO order should prioritize options while global should come only after path and environment.

roele · 2025-01-30T02:59:12Z

roele
Jan 30, 2025

Should be fixed with 2025.1.16

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`mise use --env env ...` will create a new `mise.env.toml` file even if `.mise.env.toml` already exists #4210

{{title}}

Replies: 3 comments 1 reply

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

mise use --env env ... will create a new mise.env.toml file even if .mise.env.toml already exists #4210

sgtsquiggs Jan 24, 2025

Replies: 3 comments · 1 reply

sgtsquiggs Jan 27, 2025 Author

betaboon Jan 27, 2025

roele Jan 28, 2025

roele Jan 30, 2025

`mise use --env env ...` will create a new `mise.env.toml` file even if `.mise.env.toml` already exists #4210

sgtsquiggs
Jan 24, 2025

Replies: 3 comments 1 reply

sgtsquiggs
Jan 27, 2025
Author

betaboon
Jan 27, 2025

roele
Jan 30, 2025