-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to start without GPS? #86
Comments
This was already a feature request: #10. If you have a solution for this, I will gladly accept the PR. |
I was thinking about this as I would like to see this implemented as well. I think the implementation depends on the direction you want to develop Laufhelden. I see two options: 1.Use Laufhelden for tracking Running / Cycling based activties only.ru
@jdrescher2006 What do you think? I am happy to start coding a proof of concept in my fork. |
Hi @thmichel, I would vote for your 1 solution, the second one is too complicated, makes the app less maintainable for me. Also we already have a table for all workout types, see "arrayWorkoutTypes" in the file "SharedResources.js". In this table we can add an option to mark the indoor/outdoor workouts. |
I was thinking about this issue and got some questions now. Maybe one of you guys has an idea... We have 2 separated issues. Issue 2: a workout which does not need GPS (e.g. indoor sport). Let's discuss issue 1 first: Issue 2 is a little bit easier, at least I have an idea how to do it. We would have to:
|
I originally opened the issued because of the Issue 1. When I go for bike riding, usually fire up Laufhelden, and wait for the GPS signal. And then hit start. Well I would rather turn off the screen and throw the phone to my pocket. I would vote for simply leave out points from the GPX file. I can check how meerun behaves in these situations, but before I need to put together the spec files I promised in #141 ;) |
@jdrescher2006 : sounds good. I will start looking at implementig this next week. |
@jdrescher2006 : Overlooked your second comment. |
@thmichel OK that would be an option. |
So I tested this now with Meerun. So that is our real problem here! With Laufhelden solely based on GPX files as it's data base, we don't have the ability to deal with invalid or missing GPS positions. To properly solve this, we must change the data format. Maybe to TCX or even something else. So I would say let's go with your suggestion @thmichel and make the "Start" button clickable without having GPS. |
Hi, I've published a release at https://github.com/thmichel/Laufhelden/releases that enables you to start a workout even if no GPS signal is available. Be aware that actual logging only start at GPS availability, but at least you start your workout without waiting for a signal. |
Hi @thmichel , sorry I was not very active with developing Laufhelden. |
This was fixed in some of the releases, so closing it. |
Sometimes it would be nice if the workout recording could be started without GPS.
Usually when I go for a ride I start the app and do not want to wait until the GPS signal is aciquired just start the recording and throw the phone to the pocket and call it day.
Meerun have had this feature if I remember well.
What do you think Jens? If you agree I might be able to came up with a PR.
The text was updated successfully, but these errors were encountered: