Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not test stored header facility #4

Open
jdougan opened this issue Jul 18, 2021 · 3 comments
Open

Tests do not test stored header facility #4

jdougan opened this issue Jul 18, 2021 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@jdougan
Copy link
Owner

jdougan commented Jul 18, 2021

Writing code to test HEAD responses, I realized the Silo class that is driven by the tests ignored the headers completely except sorta-kinda content-type.

@jdougan jdougan added the bug Something isn't working label Jul 18, 2021
@jdougan jdougan self-assigned this Jul 18, 2021
@jdougan
Copy link
Owner Author

jdougan commented Jul 20, 2021

On further investigation, the base Silo only stores X-SecondLife- headers and does not retrieve them!

@jdougan
Copy link
Owner Author

jdougan commented Jul 21, 2021

As of commit f7060bd the roundtrip tests check both the body data and the content type returned. There is an additional test case to check the rest of the header handling, once the handling is finished in silo.php.

@jdougan jdougan added the enhancement New feature or request label Aug 23, 2021
@jdougan
Copy link
Owner Author

jdougan commented Aug 25, 2021

The plan now is as outlined in #1 (comment) : add support for a store/retrieve key family and keep the current behavior of the X-SecondLife-* keys (store. no retrieve)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant