Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Line break not showing up #100

Open
ventz opened this issue Dec 1, 2018 · 3 comments
Open

New Line break not showing up #100

ventz opened this issue Dec 1, 2018 · 3 comments

Comments

@ventz
Copy link

ventz commented Dec 1, 2018

Hi,

Noticed that new-line breaks are not showing up correctly.

Ex:

1.) Cloud Flare's HTTPS DNS API:
https://developers.cloudflare.com/1.1.1.1/dns-over-https/json-format/

or

2.) Google's HTTPS DNS API:
https://developers.google.com/speed/public-dns/docs/dns-over-https

Under github this shows up as:
1.) Text
2.) Line

Where as under the markdown Editor, it shows up as:
1.) Text Line

@cmnguyen01
Copy link

hi can you give an html that demonstrates the issue? to have some context when testing

@aero31aero
Copy link
Collaborator

This issue has some more discussion in #108. The problem is that Github's implementation of GFM claims to ignore the line-break but the actual implementation in the comments doesn't do that:

https://babelmark.github.io/?text=test%0Amarkdown

@aero31aero
Copy link
Collaborator

I'm tempted to close this as WONTFIX because github's rendering and our rendering is the same in case of .md files in a repository (screenshot while editing README.md of this project):

image

We should aim to be consistent with how github treats the markdown files instead of how they treat comments on issues/PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants