Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing commit when creating PRs #272

Open
wusyong opened this issue May 9, 2023 · 1 comment
Open

Signing commit when creating PRs #272

wusyong opened this issue May 9, 2023 · 1 comment
Labels
question Further information is requested

Comments

@wusyong
Copy link

wusyong commented May 9, 2023

Currently, covector can't sign the commits, which makes merging PR impossible if there's a branch protection enforcing signing commits.
The only workaround is maintainer recommit with their signatures.
I would like to explore if covector can automate this.

@jbolda
Copy link
Owner

jbolda commented Jun 21, 2023

@wusyong, within the Tauri ecosystem, we are currently using the create-pull-request action to commit and open the PR. It has guidelines regarding enabling signed commits. We have looked at pulling some of this Github functionality into the action, but I anticipate that the exact same setup would be required.

https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#gpg-commit-signature-verification

@jbolda jbolda added the question Further information is requested label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants