Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unconfirmed bug in python code #59

Open
adalisan opened this issue Sep 14, 2021 · 1 comment
Open

unconfirmed bug in python code #59

adalisan opened this issue Sep 14, 2021 · 1 comment

Comments

@adalisan
Copy link

I was reading through the code, and I think this is likely a bug.

r2trimconsensus = consensus['R2'][ : r2trim]

if r2trim is None:
     r2trimconsensus = consensus['R2'][ : r2trim]

if this is true, None would be an index for the string. I think the right side was meant to be consensus['R2'] just like for r1trim. Probably not an issue in a practical sense.

@jbloom
Copy link
Member

jbloom commented Sep 14, 2021

Yes, you are correct---that is a bug. Feel free to submit a pull request if you'd like, or I can try to fix at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants