Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken precommit ci builds. #2133

Closed
Mr-Sunglasses opened this issue Nov 3, 2024 · 1 comment · Fixed by #2134
Closed

broken precommit ci builds. #2133

Mr-Sunglasses opened this issue Nov 3, 2024 · 1 comment · Fixed by #2134

Comments

@Mr-Sunglasses
Copy link
Member

While working on the PR #2132 , I've noticed precommit is broken as it can't able to build.

Environment Versions

  1. OS Type
  2. Python version: $ python -V
  3. pip version: $ pip --version
  4. pip-tools version: $ pip-compile --version

Steps to replicate

  1. ... Open a PR.
  2. ... Wait for pre-commit ci to run
  3. ... Analyze the logs

Expected result

Pre-commit ci to Run.

Actual result

https://results.pre-commit.ci/run/github/5746963/1730664892.Ada_O1p_QdCVeGicV9Y4lQ

...
@Mr-Sunglasses Mr-Sunglasses mentioned this issue Nov 3, 2024
Merged
4 tasks
webknjaz added a commit to Mr-Sunglasses/pip-tools that referenced this issue Dec 12, 2024
@Mr-Sunglasses @webknjaz
🧪 Bump MyPy Python to 3.9 @ pre-commit config
94b0149 
The `pre-commit.ci` service dropped support for Python 3.8 as it's
gone EOL. This change makes the check runnable again. It is suboptimal
as we haven't yet dropped support for Python 3.8. jazzband#2144 will address
the underlying issue more thoroughly.

Resolves jazzband#2133.

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
@webknjaz
Copy link
Member

The CI is green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🧪 Bump MyPy Python to 3.9 @ pre-commit config Mr-Sunglasses/pip-tools
2 participants
@webknjaz @Mr-Sunglasses