Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal.getConfig is not a function #18

Open
SylvainSimplonGit opened this issue May 27, 2020 · 11 comments
Open

Reveal.getConfig is not a function #18

SylvainSimplonGit opened this issue May 27, 2020 · 11 comments

Comments

@SylvainSimplonGit
Copy link

Hi,
I upgraded reveal.js to v4.0.1 and now I've this message in browser console :

VM2524 external.js:28 Uncaught TypeError: Reveal.getConfig is not a function
    at VM2524 external.js:28
    at VM2524 external.js:193

My configuration in index.html :

<script src="../reveal.js/plugin/external/external.js"></script>
 ...
<script>
Reveal.initialize({
dependencies: [
{
   src: '../reveal.js/plugin/external/external.js',
   condition: function () {
      return !!document.querySelector('[data-external],[data-external-replace]');
   }
},
...
]
...
});
</script>

Have you an idea ?

@janschoepke
Copy link
Owner

Hi,
it seems that Reveal.getConfig should also be working in Reveal.js Version > 4.0.0. Could you maybe provide an online demo of this error?

@SylvainSimplonGit
Copy link
Author

Hi,
I'm sorry but I can't host my presentation. Do you know a free temporary host?

@janschoepke
Copy link
Owner

Hi,
maybe you could try some services like jsfiddle.net or similar ones. Just put in an example presentation.

@SylvainSimplonGit
Copy link
Author

I did not manage to launch my code on stackblitz but you can find it either:

the error message :
VM2690 external.js:28 Uncaught TypeError: Reveal.getConfig is not a function
at VM2690 external.js:28
at VM2690 external.js:193
(anonymous) @ VM2690 external.js:28
(anonymous) @ VM2690 external.js:193

@SirkoS
Copy link

SirkoS commented Jun 3, 2020

Had the same issue and managed to work around the problem by using dependencies to register the plugin rather than plugins:

Reveal.initialize({
  // ...
  dependencies: [{
    src: 'node_modules/reveal_external/external/external.js', 
    condition: function() { 
       return !!document.querySelector( '[data-external],[data-external-replace]' ); 
     } 
  }, ],
});

From the documentation it seems they changed the API for plugins, so this plugin would actually need to be adapted.

@SylvainSimplonGit
Copy link
Author

@SirkoS , this is that i did, see my first comment. And it's not working for me.

@mvalahtv
Copy link

Any solution to this.I am facing same issue

@martinbe1io
Copy link

Same here :-(

Reveal.getConfig as well as Reveal.addEventListener does Not work anymore

@textreme
Copy link

Hi Jan -
Do you have plans to update reveal_external to Reveal.js v4? Would you be open to collaboration?
Thanks =)

@janschoepke
Copy link
Owner

Hi textreme,
currently I sadly don't have any time maintaining this repository. I am totally open to contributions! If you should have any improvements, you can easily send me a push request.
Jan

@janschoepke
Copy link
Owner

I also sent you a collaboration request. Feel free to join this repository! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants