-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta charset not set correctly #1
Comments
Can you manually set the meta tag somehow in order to check if it's still failing to display correctly? Isn't this issue possible because of the HTTP headers contain wrong charset information? |
Any update on this? |
@janoist1 Hi, sorry for the late reply (gotta figure a way to make github notifications more prominent...) Nope I haven't been able to solve this... How do I "set the meta tag manually"? I am using your starter kit which doesn't seem to have a conventional index.html page |
It doesn't have a static Back to your original question, have a look at these two: renderHtmlLayout and this. Try replacing the function |
Hi @janoist1 , like I said in my original post, the meta is set correctly by helmet in the resulting html, but the page doesn't render utf characters properly (charset is set as "Western - Windows 1252" in Chrome). I'm guessing this is probably because the meta is set by the browser on page load, but helmet modifies the header meta tag AFTER the page load is initiated. I forgot to mention one (important?) point: I have universal rendering set to disabled in
|
I've just checked it, and looks like it's a bug in the starter kit. I'll do some investigation and update you. Thanks for reporting it! |
thanks! just wondering if this will be fixed soon, or how should i go about fixing this. I've started a new project with your starter kit because it supports universal rendering over davezuko's starter kit, but I am going to go without server rendering initially. if this is going to take a long while/is not going to be a trivial fix then I'm gonna have to switch over to davezuko's starter-kit asap. |
If you don't need server side rendering then it's probably better (now for sure) to use Davezuko's starter kit. I'm also planning to take out the |
<meta charset="utf-8" data-react-helmet="true">
I have this line in the head when I inspect the source of the generated html, but it doesn't get set in Chrome properly (still gets set as "Western - Windows 1252" in Chrome).
Upon page load, foreign languages (in my case, Japanese) show up as gibberish and are only displayed correctly only after I select utf-8 encoding manually in Chrome.
On page load:
After selecting utf-8 manually:
The text was updated successfully, but these errors were encountered: