Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Upgrade to the latest AllenNLP version and allow gradient accumulation #3

Open
ruanchaves opened this issue Aug 17, 2020 · 1 comment
Open

[Feature Request] Upgrade to the latest AllenNLP version and allow gradient accumulation #3

ruanchaves opened this issue Aug 17, 2020 · 1 comment

Comments

@ruanchaves
Copy link

Gradient accumulation was implemented on AllenNLP at the GradientDescentTrainer class after v. 0.9.0 ( see this pull request and the current trainer code ).

As this repository uses AllenNLP v. 0.9.0, the code should be upgraded to be compatible with the latest version of AllenNLP, and num_gradient_accumulation_steps should be allowed as a parameter in src/parameters.py .
@izuna385
Copy link
Owner

Thanks for your issue. I'll upgrade and make it compatible soon!

@DRosemei DRosemei mentioned this issue Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruanchaves @izuna385