Disable imageDigest support in ztunnel controller #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have some pending work with the ztunnel images that are used as imageDigests. Because of this, when deploying Ambient profile using the OSSM operator, the ztunnel pod fails to come up. This PR temporarily disables this functionality until proper support is implemented. Alternatives: 1. Default Image: If no image details are provided in the ZTunnel CR, the operator will use the default image from the helm chart. 2. Explicitly specify image details: Following a recent fix in the ztunnel controller (PR#568), users can specify image details within the ztunnel CR itself in one of the following ways. 2.1: ztunnel.spec.values.ztunnel.image 2.2: ztunnel.spec.values.global.hub/tag Fixes: istio-ecosystem#581 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
force-pushed
the
issue-581
branch
from
81b9b67 to
1fc6b09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 75.11% 74.42% -0.70%
==========================================
Files 40 40
Lines 2504 2510 +6
==========================================
- Hits 1881 1868 -13
- Misses 534 554 +20
+ Partials 89 88 -1 ☔ View full report in Codecov by Sentry. |
|
It is important to note that this only impacts the Ambient profile, and not any usage of non-Ambient mode. |
dgn
reviewed
Jan 24, 2025
Signed-off-by: Sridhar Gaddam <[email protected]>
|
@sridhargaddam: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have some pending work with the ztunnel images that are used as imageDigests. Because of this, when deploying Ambient profile using the OSSM operator, the ztunnel pod fails to come up. This PR temporarily disables this functionality until proper support is implemented.
Alternatives:
2.1: ztunnel.spec.values.ztunnel.image
2.2: ztunnel.spec.values.global.hub/tag
Note: This change impacts on the Ztunnel image when using the Ambient profile and will not have any affect on other images.
Fixes: #581