New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not enough to make plan/comment required. Other plan/* checks should be required too. #89

Open

galargh opened this issue Dec 6, 2022 · 1 comment

Assignees

Member

galargh commented Dec 6, 2022

We could accomplish that by having a catch-all check at the end maybe?

plan/comment is not enough because skipped status doesn't block merging. That's really counter-intuitive.

galargh mentioned this issue

Revert "Revert "add rvagg as admin to go-merkledag and go-cid"" ipfs/github-mgmt#94

Closed

Member Author

galargh commented Dec 6, 2022

Found in ipfs/github-mgmt#94

galargh added this to InterPlanetary Developer Experience

galargh moved this to 🤔 Triage in InterPlanetary Developer Experience

galargh self-assigned this

galargh moved this from 🤔 Triage to 🤝 Todo in InterPlanetary Developer Experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment