Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooling-ci): connect vercel to git #4766

Merged
merged 11 commits into from
Jan 16, 2025
Merged

refactor(tooling-ci): connect vercel to git #4766

merged 11 commits into from
Jan 16, 2025

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Jan 14, 2025 •
edited
Loading

Description of change

Close #4417

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 4:25pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 4:25pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 4:25pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 4:25pm

@iota-ci iota-ci added the tooling Issues related to the Tooling team label Jan 14, 2025
@begonaalvarezd begonaalvarezd mentioned this pull request Jan 14, 2025
Closed
6 tasks
thibault-martinez
thibault-martinez reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need updates to the CI Confluence page :p

@begonaalvarezd begonaalvarezd changed the title [do not merge] refactor(tooling-ci): connect vercel to git refactor(tooling-ci): connect vercel to git Jan 14, 2025
@VmMad VmMad requested review from miker83z and a team as code owners January 14, 2025 14:17
@VmMad VmMad requested a review from a team as a code owner January 14, 2025 16:24
marc2332
marc2332 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :godmode:

@begonaalvarezd begonaalvarezd merged commit 6afee7e into develop Jan 16, 2025
38 of 39 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-ci/connect-vercel-to-git branch January 16, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@miker83z miker83z miker83z approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@kodemartin kodemartin kodemartin approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@msarcev msarcev Awaiting requested review from msarcev msarcev is a code owner

@alexsporn alexsporn Awaiting requested review from alexsporn alexsporn is a code owner

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron Dr-Electron is a code owner

@luca-moser luca-moser Awaiting requested review from luca-moser luca-moser is a code owner

@lzpap lzpap Awaiting requested review from lzpap lzpap is a code owner

Assignees

@begonaalvarezd begonaalvarezd

@VmMad VmMad

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve vercel deployments PR comment spamming
8 participants
@begonaalvarezd @thibault-martinez @kodemartin @DaughterOfMars @miker83z @marc2332 @iota-ci @VmMad