Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move-ide] The move analyzer crashes if the manifest file is missing #4387

Closed
valeriyr opened this issue Dec 6, 2024 · 1 comment · Fixed by #4791
Closed

[move-ide] The move analyzer crashes if the manifest file is missing #4387

valeriyr opened this issue Dec 6, 2024 · 1 comment · Fixed by #4791
Assignees
@valeriyr
Labels
vm-language Issues related to the VM & Language Team

Comments

@valeriyr
Copy link
Contributor

valeriyr commented Dec 6, 2024 •
edited
Loading

Bug description

The move analyzer crashes if the manifest file is missing.

Steps To reproduce the bug

  1. Create a default Move project using the following command:
iota move new xxx
  1. Delete the Move.toml file.
  2. Open the created project in Visual Studio Code with the IOTA Move extension installed.
  3. Open the ./sources/xxx.move file.
  4. Start typing something, for example, pub abc.

Actual behavior

The move analyzer crashes.

Errors

thread '<unnamed>' panicked at external-crates/move/crates/move-analyzer/src/symbols.rs:1220:49:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[Error - 6:43:06 PM] Server process exited with signal SIGABRT.
[Error - 6:43:06 PM] The Move server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
[Error - 6:43:06 PM] Delivering pending changes failed
TypeError: this.task is not a function
	at /Users/iota/.vscode/extensions/iotaledger.iota-move-1.0.0-darwin-arm64/node_modules/vscode-languageclient/lib/common/utils/async.js:28:35
	at runNextTicks (node:internal/process/task_queues:60:5)
	at process.processTimers (node:internal/timers:516:9)
@valeriyr valeriyr added the vm-language Issues related to the VM & Language Team label Dec 6, 2024
@valeriyr
Copy link
Contributor Author

valeriyr commented Dec 9, 2024 •
edited
Loading

The issue should be fixed in this PR:
MystenLabs/sui#20510

This part is the most important:

- if root_dir.is_none() && !missing_manifests.contains(&starting_path) {
-     ...
-     continue;
- }
+ if root_dir.is_none() {
+    if !missing_manifests.contains(starting_path) {
+    ...
+.   }
+    continue;
+}

@valeriyr valeriyr mentioned this issue Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriyr valeriyr

Labels
vm-language Issues related to the VM & Language Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(move-analyzer): fix crash if open a standalone Move file iotaledger/iota
1 participant
@valeriyr