Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nonce offset part of credentials file #3

Open
learner-long-life opened this issue Oct 17, 2017 · 0 comments
Open

Make nonce offset part of credentials file #3

learner-long-life opened this issue Oct 17, 2017 · 0 comments

Comments

@learner-long-life
Copy link

Currently, the nonce factory used can be different on each host from which a client calls the API, even with the same API key. This can allow one host/client to inflate the nonce, causing other host/clients to get errors back when calling the API.

The nonce offset hack to fix this is hardcoded in lib/poloniex.js but would be better off being part of the credentials file.

Future TODO: The credential file can also associate a hostname with each API key, to encourage better API key hygience (one API key per hostname).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant