Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edit, Delete modal for changing alternative names on 'Authors Page' #8731

Open
Eds-Dbug opened this issue Jan 18, 2024 · 2 comments
Open
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Design Feedback Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval

Comments

@Eds-Dbug
Copy link
Contributor

Eds-Dbug commented Jan 18, 2024

Description, Patron Story

  • New proposed design for editing and deleting alternative names to reduce redundancy of alternative names some of which are duplicates or in need of correcting.
  • For Librarians who need to search names.

Relevant Designs

Figma Design:
https://www.figma.com/file/p44gz8XqnwybK8bqN4d35T/Add-Edit-Buttons-to-Author-Buttons?type=design&node-id=0-1&mode=design&t=piyxh4xdMffH2aUq-0

Feedback Questions

Decisions

Stakeholders

@bitnapper @Eds-Dbug @openlibrary

@Eds-Dbug Eds-Dbug added Needs: Design Feedback Needs: Designs Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval labels Jan 18, 2024
@bitnapper
Copy link

Wow, it looks absolutely great. Small idea though. Many author have lots of rubbish alt-name-entries. Clicking remove and than confirm it for multiple entries can be tedious. So how about having an edit button beside the Alternative Names heading to switch in the edit mode. Then the mode switches to let you remove or edit any entry and instead of the edit button there is a save button. Only after clicking save, all changes are stored. That way you prevent accidental changes but have it a bit easier without the tedious confirmation but still prevent accidental changes.

@scottbarnes scottbarnes added Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] and removed Needs: Lead Needs: Designs Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] labels Jan 22, 2024
@cdrini
Copy link
Collaborator

cdrini commented Jan 22, 2024

See also: #8341

@cdrini cdrini added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Design Feedback Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval
Projects
None yet
Development

No branches or pull requests

4 participants