Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff rule UP007: Use X | Y for type annotations for solr #8327

Closed
RayBB opened this issue Sep 24, 2023 · 0 comments · Fixed by #8334
Closed

ruff rule UP007: Use X | Y for type annotations for solr #8327

RayBB opened this issue Sep 24, 2023 · 0 comments · Fixed by #8334
Labels
Needs: Lead Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Sep 24, 2023

Per #8236 (comment) we should be able to use those type annotations in solr now.

Will get the codebase to a more uniform style!

Proposal & Constraints

Remove the solr exclusions here and add the proper annotations.
https://github.com/internetarchive/openlibrary/pull/8252/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711

Stakeholders

@cclauss would you like to do this?
@RayBB RayBB added Type: Bug Something isn't working. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead and removed Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 24, 2023
@cclauss cclauss mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Lead Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ruff rule UP007: Use X | Y for type annotations cclauss/openlibrary
1 participant
@RayBB