Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the directory of dlrover. #1426

Open
workingloong opened this issue Jan 5, 2025 · 2 comments
Open

Refactor the directory of dlrover. #1426

workingloong opened this issue Jan 5, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request todo issue or pr with 'todo' will ignore expiration
Milestone

Comments

@workingloong
Copy link
Collaborator

workingloong commented Jan 5, 2025

Now, the directory name of dlrover is confused. The folders under dlrover are dlrover/python, dlrover/client, dlrover/trainer, dlrover/go, dlrover/proto. The dlrover/go and dlrover/python are named by the programming language, but the dlrover/trainer, dlrover/proto and dlrover/client are named by the function module. What's more, the dlrover folder is used to build a python package but the dlrover/go is not packaged in the dlrover wheel.

The folders can be re-organized the following structure.

|-dlrover
   |-client
   |-proto
   |-trainer
   |-master
   |-agent
|-go
   |-brain
   |-elasticjob
   |-master
@bobsongplus
Copy link

bobsongplus commented Jan 15, 2025

Does have a plan to implement brain and master in Golang? I found the code of brain and master is on early stage.

@workingloong
Copy link
Collaborator Author

Yes, I’ll submit the refactor design of master soon. But, we need to discuss whether to keep the brain which is not commonly used.

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Jan 26, 2025
@BalaBalaYi BalaBalaYi added this to the Backlog milestone Jan 26, 2025
@BalaBalaYi BalaBalaYi added the todo issue or pr with 'todo' will ignore expiration label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo issue or pr with 'todo' will ignore expiration
Projects
None yet
Development

No branches or pull requests

7 participants