Thermald does not throttle the intel_cpufreq CPU scaling driver

[DougSmythies]

If the thermald service is started while using the intel_pstate CPU frequency driver, everything is fine and thermal control is done via /sys/devices/system/cpu/intel_pstate/max_perf_pct.

If the thermald service is already running and then the intel_pstate CPU frequency scaling driver is changed to the intel_cpufreq driver (A.K.A. the intel_pstate driver in passive mode), everything continues to be fine and thermal control is done via /sys/devices/system/cpu/intel_pstate/max_perf_pct.

If the thermald service is started while using the intel_cpufreq CPU frequency scaling driver, it does not work.

I have cloned this repository, but have not been able to figure it out.

I am using very simple controls:
thermald-xml-files.txt

Version: 2.5.6-2ubuntu0.24.04.1

[spandruvada]

Please try this change:
git diff
diff --git a/src/thd_cdev_intel_pstate_driver.cpp b/src/thd_cdev_intel_pstate_driver.cpp
index 4d20aeb..0fe32b0 100644
--- a/src/thd_cdev_intel_pstate_driver.cpp
+++ b/src/thd_cdev_intel_pstate_driver.cpp
@@ -106,7 +106,7 @@ int cthd_intel_p_state_cdev::update() {
ret = cdev_sysfs.read(status_attr.str(), status_str);
if (ret >= 0 && status_str != "active") {
thd_log_info("intel pstate is not in active mode\n");

•                   return THD_ERROR;
  

•                   //return THD_ERROR;
            }
    }
  

I

I did one experiment:

thermald_log.txt

[DougSmythies]

Yes, that works.
I tried the change and it worked as expected, fixing the issue.

[spandruvada]

I will submit to next rev. Thanks for test.