Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

operator: per-container resource spec #616

Closed
pohly opened this issue Apr 24, 2020 · 2 comments
Closed

operator: per-container resource spec #616

pohly opened this issue Apr 24, 2020 · 2 comments
Assignees
Labels

Comments

@pohly
Copy link
Contributor

pohly commented Apr 24, 2020

ControllerResources and NodeResources have a conceptual problem: the values are applied to all containers in the two pods. As it stands now, users have to specify the maximum of all requirements and then some containers will run with higher limits than really needed.

Right now, the default values are probably (?) arbitrary, too.

@pohly pohly added the future needs to be fixed in some future release label May 18, 2020
@pohly pohly added 0.8 needs to be fixed in 0.8.x and removed future needs to be fixed in some future release labels Jun 18, 2020
@pohly
Copy link
Contributor Author

pohly commented Jun 22, 2020

kubernetes-csi/csi-driver-host-path#47 is a similar issue for the hostpath driver example.

@pohly pohly mentioned this issue Sep 30, 2020
5 tasks
@pohly pohly added 0.9 and removed 0.8 needs to be fixed in 0.8.x labels Oct 2, 2020
@pohly
Copy link
Contributor Author

pohly commented Oct 2, 2020

Didn't make it into 0.8. Let's move it to 0.9.

avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 14, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requests/limits are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 14, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requests/limits are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 16, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 24, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 24, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 25, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Nov 26, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Dec 2, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Dec 2, 2020
Moving the deployment API to `v1beta1` along with supporting per-container
resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Dec 8, 2020
Made changes to the `v1beta1` deployment API to support configuring
per-container resources.

In Kubernetes resource requiremets are per-container. Existing
`ControllerResources` and `NodeResources` API fields are not suffice to
configure resources for sidecar containers. Hence added new fields to
deployment specification for per-container resources.

Also chose the default cpu,memory resource requests/limits for the
containers as suggested by the VPA (Verticall Pod Autoscaler).

TODOS:
- To support deprecated `v1alpha1` API, needs a conversion webhook in
the cluster to handled conversions between different API versions.

FIXES: intel#616
@pohly pohly closed this as completed in 62f12c5 Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants