Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to avoid duplication among generated assert constants in .llir file #3054

Open
anmyachev opened this issue Dec 20, 2024 · 0 comments
Open

Try to avoid duplication among generated assert constants in .llir file #3054

anmyachev opened this issue Dec 20, 2024 · 0 comments
Labels
codegen: mlir enhancement New feature or request
Milestone
0.3 [Triton] Lang...

Comments

@anmyachev
Copy link
Contributor

Discovered in #2790

Example from test_scan_layouts[True-1-src_layout10-64-32]:

@assertFunc_447 = internal addrspace(1) constant [8 x i8] c"unknown\00"
@assertFile_447 = internal addrspace(1) constant [87 x i8] c".../pytest-0/test_scan_layouts_True_1_src_l0/test_scan_layouts.ttgir\00"
@assertMessage_447 = internal addrspace(1) constant [18 x i8] c"overflow detected\00"

According to the example above, there are more than 400 constants with the same values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen: mlir enhancement New feature or request
Projects
None yet
Milestone
0.3 [Triton] Language and Runtime
Development

No branches or pull requests
2 participants
@anmyachev @vlad-penkin