Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_response doesn't take into account the response code #31

Open
brendonlow opened this issue Dec 6, 2018 · 0 comments
Open

handle_response doesn't take into account the response code #31

brendonlow opened this issue Dec 6, 2018 · 0 comments

Comments

@brendonlow
Copy link

brendonlow commented Dec 6, 2018

pandarus-0.7.0/lib/pandarus/remote_collection.rb:43

The response doesn't take into account response_code so error responses are being returned without any messaging as if valid data.

It should probably raise an error appropriate for the situation rather than passing through ‘unknown’ data to the virtus gem and having it raise an error due to the ‘unknown’ data being invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant