New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect naming #15

Open

kuldeepdhaka opened this issue Aug 2, 2016 · 2 comments

Contributor

kuldeepdhaka commented Aug 2, 2016

https://github.com/insane-adding-machines/unicore-mx/blob/master/include/unicore-mx/stm32/common/adc_common_v2_single.h#L52
should be ADC_CFGR1_EXTSEL_MASK

The text was updated successfully, but these errors were encountered:

Contributor Author

kuldeepdhaka commented Aug 2, 2016

unicore-mx/include/unicore-mx/stm32/f0/adc.h

Line 82 in cfc738c

#define ADC_SMPR_SMP (7 << ADC_SMPR_SMP_SHIFT)

should be ADC_SMPR_SMP_MASK

Member

brabo commented Aug 4, 2016

@kuldeepdhaka entirely correct, nice catch!
We can fix these, but we should note this down to check the headers for items as this with the overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment