Allow cost model to be called without an actual witness #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support only one polynomial commitments scheme. * Rename ModelCircuit -> CircuitModel
Avoid running MockProver for cost model We copied the `Assignment` implementation of the MockProver, but in here we do not need to unwrap the witnesses (which was why the MockProver always needed `Value::known` instead of `Value::unknown`. Now we can run the cost model without assigned values.
iquerejeta
force-pushed
the
iquerejeta/minor_update
branch
from
674a9ff to
b5053c0
Compare
miguel-ambrona
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
This is great!
It would be even better if from_circuit_to_circuit_model did not take the instances. I believe we are not really doing anything with them. Maybe you need to get the length of every instance column, but that would already be better than a whole vector of instances.
Still, it would be great not to have to deal with the instances in any way.
|
Maybe now that you have control of the query_instance. You can keep track of the max row this function is being called on every column. Thus obtaining the expected nb of public inputs per instance col. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create an object that runs
Synthesise, similar to the mock prover, but without unwrapping the witnesses. Now we just extend the number of rows for every new row used in a witness assignment, but we don't try to extract its value.This enables running the cost model without a witness.
We also remove the support to different commitment schemes, as we currently only support KZG.
Closes #28