Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): Add Chain Follower metrics to improve observability #1529

Merged
merged 17 commits into from
Jan 23, 2025
Merged

feat(cat-gateway): Add Chain Follower metrics to improve observability #1529

merged 17 commits into from
Jan 23, 2025

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jan 16, 2025 •
edited
Loading

Description

We have metrics for the chain follower already, and they need to be exposed via the prometheus metrics system we have in cat-gateway).

Related Issue(s)

Closes #1497

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added draft Draft rust Pull requests that update Rust code labels Jan 16, 2025
@apskhem apskhem self-assigned this Jan 16, 2025
@apskhem apskhem linked an issue Jan 16, 2025 that may be closed by this pull request
Add Chain Follower metrics to improve observability #1497
Closed
@apskhem apskhem marked this pull request as draft January 16, 2025 10:57
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Jan 21, 2025
@apskhem apskhem marked this pull request as ready for review January 21, 2025 07:02
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@apskhem apskhem requested a review from stevenj January 21, 2025 10:57
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 412/412}$ | ${\color{red}Fail: 0/412}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 412/412}$ | ${\color{red}Fail: 0/412}$ |

stevenj
stevenj approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) January 23, 2025 07:58
@stevenj stevenj merged commit 7c1656f into main Jan 23, 2025
36 checks passed
@stevenj stevenj deleted the feat/chain-follower-metrics branch January 23, 2025 08:14
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 412/412}$ | ${\color{red}Fail: 0/412}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach is a code owner

Assignees

@apskhem apskhem

Labels
review me PR is ready for review rust Pull requests that update Rust code
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Chain Follower metrics to improve observability
2 participants
@apskhem @stevenj