Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): Improve observability and metrics #1495

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat(cat-gateway): Improve observability and metrics #1495

merged 5 commits into from
Jan 15, 2025

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jan 9, 2025 •
edited
Loading

Description

We need to collaborate to get useful and appropriate metrics between the Devs and SRE.

Related Issue(s)

Closes #1480

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem
refactor(cat-gateway): Restructure cat-gateway metrics module (#1483)
765f7e1 
* feat: initial files

* refactor: new structure
@apskhem apskhem added draft Draft comment me Request for comments labels Jan 9, 2025
@apskhem apskhem linked an issue Jan 9, 2025 that may be closed by this pull request
🛠️ [TASK] : Improve cat-gateway observability #1480
Open
4 tasks
@apskhem apskhem marked this pull request as draft January 9, 2025 13:10
@apskhem apskhem added the rust Pull requests that update Rust code label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

stevenj
stevenj previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Mr-Leshiy
Mr-Leshiy previously requested changes Jan 14, 2025
View reviewed changes
catalyst-gateway/bin/src/metrics/endpoint.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/metrics/endpoint.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/metrics/endpoint.rs Show resolved Hide resolved
catalyst-gateway/bin/src/metrics/endpoint.rs Outdated Show resolved Hide resolved
catalyst-gateway/bin/src/metrics/endpoint.rs Outdated Show resolved Hide resolved
@apskhem @Mr-Leshiy
chore: clean unused clippy lint
49658ce 
Co-authored-by: Alex Pozhylenkov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

stevenj
stevenj approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj marked this pull request as ready for review January 15, 2025 03:21
@stevenj stevenj merged commit e169a08 into main Jan 15, 2025
41 checks passed
@stevenj stevenj deleted the feat/improve-observability branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach is a code owner

Assignees

@apskhem apskhem

@cong-or cong-or

Labels
comment me Request for comments draft Draft rust Pull requests that update Rust code
Projects
Catalyst
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Improve cat-gateway observability
4 participants
@apskhem @stevenj @Mr-Leshiy @cong-or