Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Finalize CRUD operations for E.O.S Wallets #36

Closed
KtorZ opened this issue Nov 7, 2018 · 3 comments
Closed

Finalize CRUD operations for E.O.S Wallets #36

KtorZ opened this issue Nov 7, 2018 · 3 comments
Assignees
Labels
ACCEPTED ADR has been accepted RESTROSPECTIVE ADR needs restrospective session

Comments

@KtorZ
Copy link
Contributor

KtorZ commented Nov 7, 2018

Context

Until here, we didn't need the remaining classic CRUD operations on E.O.S. wallets.

Decision

For completeness and because we want to make our users happy, let's implement (and test) them.

Acceptance Criteria

    • The API must support 'Read' operation on E.O.S. Wallets.
    • The API must support 'Update' operation on E.O.S. Wallets.
    • The API must support 'Delete' operation on E.O.S. Wallets.
    • The API must support 'List' operation on E.O.S. Wallets.

PR

Number Base
#278 develop
#304 develop

Consequences

@KtorZ KtorZ added this to the (BIP-44) E. We Can Read, Update, Delete & List E.O.S. Wallets milestone Nov 7, 2018
@KtorZ KtorZ added the ACCEPTED ADR has been accepted label Nov 14, 2018
@KtorZ KtorZ modified the milestones: (BIP-44) E. We Can Read, Update, Delete & List E.O.S. Wallets, Address Derivation à la BIP-44 Nov 23, 2018
@denisshevchenko denisshevchenko self-assigned this Jan 28, 2019
@piotr-iohk
Copy link
Contributor

@denisshevchenko, @KtorZ
There is no QA section on the ticket, however I understand that it is an old format. :)
In any case, in terms of QA, I think we should add some integration tests for CRUD operations. Probably we want to approach this in different task? (I haven't found any, so if there is one can you point me to it pls?).

There are some tests already added in #236. But they only touch on create and read. There are no tests covering list, update, delete.

@KtorZ
Copy link
Contributor Author

KtorZ commented Feb 8, 2019

Indeed there's no QA / tests for this yet. I'll leave that decision to @denisshevchenko here; would you rather write them as part of this ticket? Or should we open another ticket a bit like #236 where you or I can write those integration tests?

@piotr-iohk
Copy link
Contributor

@denisshevchenko I'm closing this one. As discussed I'll be adding more integration tests for EOS wallets CRUD operations under #331.

@piotr-iohk piotr-iohk added the RESTROSPECTIVE ADR needs restrospective session label Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ACCEPTED ADR has been accepted RESTROSPECTIVE ADR needs restrospective session
Projects
None yet
Development

No branches or pull requests

3 participants