Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with other mods shields that have abilities #45

Open
gusbaruc opened this issue Jul 5, 2024 · 1 comment
Open

Issues with other mods shields that have abilities #45

gusbaruc opened this issue Jul 5, 2024 · 1 comment

Comments

@gusbaruc
Copy link

gusbaruc commented Jul 5, 2024

Mod version: 1.1.7a
MC version: 1.19.2
Forge version: 43.4.0

This mod has some issues with shields that have abilities, from other mods.
After config shields via datapack, the basic shield mechanics works normally, as intended by the mod, but for some reason the abilities stop working. I recorded a demo video to show it off.

In the example below I used 3 items for demonstration:

  • The Corrupted Shield from Enderman Overhaul mod that, when defending, has the ability to teleport the enemy to a nearby location
  • The Shield of the Deep from Alex's Mobs that, when defending, has the ability to deal thorns damage to enemies
  • The Ray of Siphoning spell from Iron's Spell n Spellbooks. This is a different case from the others and a bit more specific. Maybe it can help understand what is causing the problem. Since it's a continuous spell, where you need to hold down the right button to continue casting the blast, it seems that for some reason the shield blocks this action.

The first video demonstrates the expected behavior, without the mod installed.
https://github.com/infernalstudios/Shield-Expansion/assets/57414280/51198a21-ea54-4321-ac22-7e48124d8c12

The second one is with Shield Expansion installed, showing the problem.
You will notice that I test each item twice, where the first one doesn't work and the second one works. I think this is another interesting point to pay attention to.
https://github.com/infernalstudios/Shield-Expansion/assets/57414280/43214abd-c497-4dfa-bcb3-36d6147578db
In the first test, I simply raise the shield with the right button and hold it. In this case, the shield abilities do not work. The magic thrown by the staff starts the animation, but is canceled immediately after, as if I had released the attack button.

In the second test you can see that right before I raise the shield and hold down the right button, I perform an attack with the left button. For some reason this causes the shield abilities to work that is intend. The same goes for the staff's magic. I perform an attack with the left button and then hold the right button. Now the blast remains continuous until I release the button or the magic bar runs out. The attack no longer cancels itself.

I hope I was clear enough and my report helps to find the problem. If you have any other questions, feel free to ask.

@DragonacyCX
Copy link

DragonacyCX commented Dec 8, 2024

I'm seconding this, yeah this issue is inconvenient since I wanna give stats to shields in my modpack like more stamina, but for special shields to work I gotta untag them from the Shield Exp shield list, thus giving them infinite stamina. (This happens in the other versions too btw, I'm using 1.20.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants