Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke testing with npm modules #14

Open
indutny opened this issue Jun 18, 2016 · 6 comments
Open

Smoke testing with npm modules #14

indutny opened this issue Jun 18, 2016 · 6 comments

Comments

@indutny
Copy link
Owner

indutny commented Jun 18, 2016

One of the main goals for this project is to be used in the node-gyp. This means, though, that we should make sure that the most of the existing binding.gyp files will work with gyp.js. Thus, "smoke testing" is needed badly.

cc @thealphanerd

@MylesBorins
Copy link

@indutny are you thinking that this module should be included in citgm? or did you have something else in mind?

@indutny
Copy link
Owner Author

indutny commented Jun 18, 2016

@thealphanerd it may be a good idea to include it in cigtm eventually, indeed. However, I was thinking about doing the smoke tests for node.js addons. Added you to cc, because you have tons of experience with smoke testing 😉

@MylesBorins
Copy link

definitely interested in helping with this.

If you can come up with a list of requirements I can definitely start digging in.

Specifically outlining the manual process for make sure that the most of the existing binding.gyp files will work with gyp.js would help

@indutny
Copy link
Owner Author

indutny commented Jun 18, 2016

@thealphanerd thank you!

What about something like this:

  • Have a list of node.js addons that are known to work on linux/windows/osx/..., or at least know on which platform npm test passes
  • Build these packages with patched node-gyp (See: shared_library support #2 (comment), WIP)
  • Run npm test on each of them

@MylesBorins
Copy link

So citgm allows you to provide a custom lookup table, so we could easily make a lookup table of only native modules. Is there a flag or env var that can be passed to npm to use a specific gyp? If so I think this should be pretty painless to do with citgm, we may even be able to do it with the off the shelf citgm

@indutny
Copy link
Owner Author

indutny commented Jun 18, 2016

@thealphanerd sounds lovely! I'll get back to you once we will get things moving with node-gyp. Thank you so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants