Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findOutgoingLinks method should return only URLs in <a> tags #33

Open
aaronpk opened this issue Aug 23, 2017 · 0 comments
Open

findOutgoingLinks method should return only URLs in <a> tags #33

aaronpk opened this issue Aug 23, 2017 · 0 comments

Comments

@aaronpk
Copy link
Member

aaronpk commented Aug 23, 2017

Currently the findOutgoingLinks method will return any mf2 property that is a URL, regardless of the element the value came from. For example, <data class="u-in-reply-to" value="http://example.com/"> will be considered a link, even though according to HTML it is not a link. This is a problem because sending a webmention to that URL will fail when its webmention endpoint tries to look for a link back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant