Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to mark document as curation-finished if a required document-level annotation feature is missing #4866

Open
reckart opened this issue Jun 11, 2024 · 3 comments
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented Jun 11, 2024

Describe the bug
If a document has been opened in sidebar-curation mode and a document-level annotation with a required feature has been added (e.g. manually or via a singleton), then the document cannot be marked as curation-finished on the curation page (also not on the annotation page in curation mode probable). However, on the curation page, this is quite annoying because there is no way to access document-level annotations on the curation page.

To Reproduce
Steps to reproduce the behavior:

  1. Create document-level annotation layer with required feature
  2. Create annotation of that layer while in sidebar-curation mode on the annotation page but do not fill in required feature
  3. Open the document on the curation page and try marking it as finished
  4. See error

Expected behavior
Probably the best would be if document-level annotations could be properly curated.

Please complete the following information:

  • Version and build ID: 32.3
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Jun 11, 2024
@reckart reckart added this to the 34.1 milestone Jun 11, 2024
@reckart reckart self-assigned this Jun 11, 2024
@PotOfJam
Copy link

Can you explain the 2. of your reproduction methodology ? i'm not sure of what you are talking about when you say "sidebar-curation mode".

Also i'm pretty sure you made a mistake in the version of the next milestone, it should be 33.1 not 34.1.

Can we agree that at the time there is no way to curate document-level annotation ?

@reckart
Copy link
Member Author

reckart commented Jun 11, 2024

Sidebar curation mode is an experimental mode that allows curating documents on the annotation page. It works ok but there are a few quirks.

In that mode, it is also possible to switch to the document-level annotation sidebar and make annotations there. True curation is not possible because you will only see the document-level annotations of the curator, not those of the annotators.

I do not think a fix for this will make it into the 33.x series since adding document-level curation will be a larger task. If a fix makes it into 33.x, then it would be some kind of workaround that ignores document-level features during validation when closing a document on the curation page.

@reckart reckart modified the milestones: 34.1, 34.0 Jun 11, 2024
@PotOfJam
Copy link

Okay thanks for the answer

@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🔖 To do in Kanban Aug 7, 2024
@reckart reckart modified the milestones: 34.0, 35.0 Sep 7, 2024
@reckart reckart modified the milestones: 35.0, 36.0 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 To do
Development

No branches or pull requests

2 participants