Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] function return message inverted #52

Closed
5 tasks done
SanderDevisscher opened this issue Jul 31, 2024 · 0 comments · Fixed by #53
Closed
5 tasks done

[BUG] function return message inverted #52

SanderDevisscher opened this issue Jul 31, 2024 · 0 comments · Fixed by #53
Assignees
Labels
bug Something isn't working Function Issue related to a function

Comments

@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Jul 31, 2024

Welke functie/dataset
col_content_compare

Beschrijf de bug
De return message is inverted. for example when using the example we get this message:

[1] "Values missing from dataset1$b but in dataset2$b:"
[1] "c"
[1] "Values missing from dataset2$b but in dataset1$b:"
[1] "f"

while we would expect:

[1] "Values missing from dataset2$b but in dataset1$b:"
[1] "c"
[1] "Values missing from dataset1$b but in dataset2$b:"
[1] "f"

Stappen om de bug te reproduceren:
Take a good look at the example

Verwachte uikomst
Correct message is returned

package - versie
‘1.1.2’

Checklist

  • corrigeer bug
  • voer devtools::check() uit in de console
  • los eventuele errors, warnings en notes1 op
  • increment versie dmv usethis::use_version(which = "patch")2
  • maak een pull request met @soriadelva of @SanderDevisscher en eventueel andere relevante gebruikers als reviewer.

1in de mate van het mogelijke

*2Indien het nodig is om de functie grotendeels te herzien (bvb tgv een depricated package) om de bug op te lossen of als er meerdere functies en/of datasets bij betrokken zijn, gebruik: usethis::use_version(which = "minor"). *

@SanderDevisscher SanderDevisscher added bug Something isn't working Function Issue related to a function labels Jul 31, 2024
@SanderDevisscher SanderDevisscher self-assigned this Jul 31, 2024
SanderDevisscher added a commit that referenced this issue Jul 31, 2024
@SanderDevisscher SanderDevisscher linked a pull request Jul 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Function Issue related to a function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant