Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose in get_dep_no_obs() #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rafnuss
Copy link
Collaborator

@Rafnuss Rafnuss commented Jan 3, 2025

When using get_*() and map_dep() with a species filter, it is expected that some of my deployements won't have any observations of this species. I find the list of deployements display unecessary and suggest to have a verbose argument to the function.

> get_rai(pkg, species = "Suni")
There are 103 deployments without observations: 2022-05-13_L5_c10, 2020-11-10_K3_c05, 2021-06-26_I6_c09, 2020-08-29_G8_c09, 2021-04-25_F4_c01, 2020-08-29_H9_c03, 2020-01-14_I7_C10, 2022-02-27_K5_c09, 2021-09-03_C2_c10, 2022-05-13_M5_c09, 2019-11-07_k7_C01, 2019-08-23_j8_c03, 2020-01-13_h8_c07, 2021-06-26_K7_c05, 2019-04-17_i9_C09, 2022-02-26_D5_c01, 2020-01-14_J7_C09, 2020-05-27_G4_c10, 2019-09-21_h7_C07, 2020-05-28_H4_c09 and others..

@damianooldoni
Copy link
Member

Hi @Rafnuss: thanks for this contribution. Really appreciated!
My thoughts:

  1. We shouldn't implement this in main, see my comment Remove read_wi() from camtraptor #351 (comment). I try to avoid adding new functionalities in main as I would like to finalize camtraptor version 1.0 asap. Doing this in main will result in a lot of conflicts when trying to pull changes in dev branch version-1.0.
  2. Implement verbosity at package level, see discussion in related issue Add verbose in get_dep_no_obs() #356
  3. I prefer to do this later on: something for camtraptor 1.1.

@damianooldoni
Copy link
Member

@Rafnuss: is it ok if I add label "on hold" for this PR? I don't want to close it as it is a very good reminder for all of us.

@Rafnuss
Copy link
Collaborator Author

Rafnuss commented Jan 6, 2025

@Rafnuss: is it ok if I add label "on hold" for this PR? I don't want to close it as it is a very good reminder for all of us.

Yes, make sense to update the entire package with this package level verbosity. I like the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants