Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using RDConnect_RNASeq for input to SmartRNASeqCaller #4

Open
brianjohnhaas opened this issue Sep 5, 2019 · 4 comments
Open

Using RDConnect_RNASeq for input to SmartRNASeqCaller #4

brianjohnhaas opened this issue Sep 5, 2019 · 4 comments

Comments

@brianjohnhaas
Copy link

Hi,

I used your nextflow workflow from here:
https://github.com/inab/RDConnect_RNASeq

to generate a gatk vcf file to be used as input to SmartRNASeqCaller.

The final output from running RDConnect_RNASeq is:
Step8_out.filtered.g.vcf

which contains PASS variants along with all those with filter fields set to non-pass values.

If I use this as input to SmartRNASeqCaller, it ends up selecting some non-pass variants as 'ok' variants.

Should we be running SmartRNASeqCaller on only the PASS variants from this vcf file?

thanks!

@brianjohnhaas
Copy link
Author

I think I see the problem. The final output from running the genotyper isn't copied ('published' as per nextflow) into the specified output directory in the nextflow workflow.

@mbosio85
Copy link
Collaborator

mbosio85 commented Sep 6, 2019

Hi,

It look you already found that the answer to your question is that we used the 'PASS' variants as input for SmartRNASeqCaller.
Thanks for looking into the code and finding the issue in the RD_Connect_RNASeq pipeline :)
I'll update the code so that the correct file is in the output directory.

Cheers
Mattia

@brianjohnhaas
Copy link
Author

brianjohnhaas commented Sep 6, 2019 via email

@PrincescaDorsaint
Copy link

Hi @mbosio85

Sorry for the late response. I just wanted to let you know that the adjustments you made on your pipeline now works with my VCF's.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants