Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV file with empty cells is getting parsed #762

Open
thisismayuresh opened this issue Aug 20, 2024 · 1 comment
Open

CSV file with empty cells is getting parsed #762

thisismayuresh opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@thisismayuresh
Copy link
Collaborator

Describe the bug
When parsing and importing CSV file with empty cell values, it's getting imported and showing in import widget. The empty lines looks like this,

,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,

To Reproduce
Steps to reproduce the behaviour:

  1. Create Import and Add columns
  2. Try importing CSV file with empty field values. (As described above)
  3. Upload, Do Mapping and check in review step, the empty rows will be shown.

Expected behaviour
Empty rows should not be imported and shown in review step.

Screenshots
image

Additional context
May we can work here
https://github.com/implerhq/impler.io/blob/next/apps/api/src/app/review/usecases/do-review/base-review.usecase.ts#L327
And here,
https://github.com/implerhq/impler.io/blob/next/apps/api/src/app/review/usecases/do-review/base-review.usecase.ts#L472

@thisismayuresh thisismayuresh added the bug Something isn't working label Aug 20, 2024
@thisismayuresh
Copy link
Collaborator Author

mholt/PapaParse#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant