We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VavrMapEncoding adds Entry prefix for tuple related operations. Current solution has some drawbacks:
VavrMapEncoding
Entry
putBar(Map.Entry<? extends K, ? extends V>)
How about replacing:
@Encoding.Naming(value = "putEntry*", depluralize = true) with @Encoding.Naming(standard = Encoding.StandardNaming.PUT)
@Encoding.Naming(value = "putEntry*", depluralize = true)
@Encoding.Naming(standard = Encoding.StandardNaming.PUT)
@Encoding.Naming(value = "setEntries*") with @Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL) ?
@Encoding.Naming(value = "setEntries*")
@Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)
Also, I would consider replacing @Encoding.Naming(value = "setJavaMap*") with @Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)
@Encoding.Naming(value = "setJavaMap*")
The text was updated successfully, but these errors were encountered:
I'm open to patches for this, if you have them! I've had very little time to work on this project lately. 😓
Sorry, something went wrong.
No branches or pull requests
VavrMapEncoding
addsEntry
prefix for tuple related operations.Current solution has some drawbacks:
putBar(Map.Entry<? extends K, ? extends V>)
method )How about replacing:
@Encoding.Naming(value = "putEntry*", depluralize = true)
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT)
@Encoding.Naming(value = "setEntries*")
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)
?
Also, I would consider replacing
@Encoding.Naming(value = "setJavaMap*")
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)
The text was updated successfully, but these errors were encountered: