Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: workaround for prometheus client issue with conflicting sets of labels #60

Closed
eledhwen opened this issue Apr 16, 2024 · 0 comments · Fixed by #64
Closed

Metrics: workaround for prometheus client issue with conflicting sets of labels #60

eledhwen opened this issue Apr 16, 2024 · 0 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@eledhwen
Copy link
Collaborator

Introduce a workaround for the known issue with metrics having different sets of labels (prometheus/client_java#696) in which case the micrometer prometheus exporter may end up not showing some metrics (micrometer-metrics/micrometer#4091)

The idea is to do something not unlike what they did over at temporal.io (temporalio/sdk-java#230) where they just add all labels with default values ; in our case that would mean having some mechanism for keeping track of possible label keys for each metric, and set an empty string if the label wasn't explicitly mentioned in the context.

@eledhwen eledhwen self-assigned this Apr 16, 2024
@eledhwen eledhwen added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant