Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🟢 :k8s: O2 - community ownership of the Kubernetes Conformance Bot #1

Open
4 of 7 tasks
hh opened this issue Jul 31, 2023 · 15 comments
Open
4 of 7 tasks

🟢 :k8s: O2 - community ownership of the Kubernetes Conformance Bot #1

hh opened this issue Jul 31, 2023 · 15 comments
Assignees

Comments

@hh
Copy link
Member

hh commented Jul 31, 2023

ii folks the only people maintaining the k8s-conformance-bot, this needs to change. It will require buy in from #sig-k8s-infra

Key Results:

  • KR1 - k8s-conformance-bot is donated to #sig-k8s-infra
  • KR2 - the workflow happens completely within the k8s community repositories
  • KR3 - the AWS Resources are moved from CNCF to Kubernetes community account

Remaining Steps:

In order to have community ownership of the Kubernetes Conformance Verification Bot
As a #sig-k8s-infra maintainer
I want the k8s-conformance-bot to be fully accessible and maintainable by the community

As a vendor
I want have easy to understand feedback if my submission is incorrect

As Taylor Wagoner
I want to easy interactions with the cncf/k8s-conformance submissions

Given a request to change the k8s-conformance-bot code
When I create a PR to change the logic
Then the workflow happens completely within the k8s community repositories and AWS accounts
@hh hh added this to CNCF OKRs Jul 31, 2023
@hh hh converted this from a draft issue Jul 31, 2023
@hh hh changed the title k8s-conformance-bot community ownership of Kubernetes Conformance vendor submission process Jul 31, 2023
@hh hh changed the title community ownership of Kubernetes Conformance vendor submission process O2 - community ownership of Kubernetes Conformance vendor submission process Jul 31, 2023
@hh hh changed the title O2 - community ownership of Kubernetes Conformance vendor submission process 🟢 O2 - community ownership of Kubernetes Conformance vendor submission process Jul 31, 2023
@hh hh changed the title 🟢 O2 - community ownership of Kubernetes Conformance vendor submission process 🟢 O2 - community ownership of the Kubernetes Conformance Verification Jul 31, 2023
@hh hh changed the title 🟢 O2 - community ownership of the Kubernetes Conformance Verification 🟢 :k8s: O2 - community ownership of the Kubernetes Conformance Verification Jul 31, 2023
@hh hh changed the title 🟢 :k8s: O2 - community ownership of the Kubernetes Conformance Verification 🟢 :k8s: O2 - community ownership of the Kubernetes Conformance Bot Jul 31, 2023
@BobyMCbobs
Copy link
Member

k8s-conformance-bot is donated to #sig-k8s-infra

Do you possibly mean sig-arch?

@BobyMCbobs
Copy link
Member

kubernetes/org#4706

@hh
Copy link
Member Author

hh commented Jan 24, 2024

@BobyMCbobs can you write up documentation for all the accounts and services required for the Conformance Bot
#sig-arch will need a way to provide self-management of those accounts and resources (and how they are deployed and managed)

@BobyMCbobs
Copy link
Member

@hh, I'm not sure what those accounts or services would be other than GitHub and the GitHub app used for installing on a repo. Those aren't required since the kubernetes-sigs org has it's own Prow instance which should be nearly ready to go.

Thinking right now, the most we might need to coordinate is

  • with Taylor or Jorge on the k8s-conformance repo having prow.k8s.io installed onto it
  • ensuring the verify-conformance app gets deployed

@hh
Copy link
Member Author

hh commented Jan 28, 2024 via email

@BobyMCbobs
Copy link
Member

Probably need to migrate from prow.cncf.io to prow.k8s.io
Do you have the deployment configuration?

@hh, it is currently configured here
https://github.com/cncf-infra/verify-conformance/tree/main/config
and shouldn't need to see much change

@hh
Copy link
Member Author

hh commented Jan 29, 2024

Noting there is another project tracking this Objective:
https://github.com/orgs/ii/projects/11

@hh
Copy link
Member Author

hh commented Jan 29, 2024

I think the other document I was looking for is here:
https://github.com/cncf-infra/verify-conformance/blob/main/docs/resources.md

@hh
Copy link
Member Author

hh commented May 16, 2024

Let's prioritize the AWS Infrastructure migration first from CNCF AWS accounts to Kubernetes.

@BobyMCbobs
Copy link
Member

BobyMCbobs commented May 21, 2024

There is no fast path on this, due to timezone coordination and verify-conformance app deployment.

Updated migration todos are in the top comment now.

Some notes

@BobyMCbobs
Copy link
Member

BobyMCbobs commented May 27, 2024

Looking at which pieces will need to be teared down outta AWS and it looks like cncf-infra/prow-config//infra/aws and cncf-infra/aws-infra//terraform/iam are the two repos. These two repos in cncf-infra and several others will be likely candidates for repo archival.

@BobyMCbobs
Copy link
Member

Looking at https://github.com/cncf-infra/aws-infra/blob/main/terraform/iam/providers.tf#L20-L55

IMPORTANT: the cncf-infra/aws-infra repo should not be entirely teared down. Only the following type of resources should be destroyed:

  • verify-conformance related
  • prow-config repo related

There's three providers for aws into the follow respective accounts

  • registry-k8s-io: now under Kubernetes AWS OU -> k8s-infra-aws-admins+registry-k8s-io
  • k8s-infra-accounts: now under Kubernetes AWS OU -> transitional OU -> k8s-infra-aws-admins+accounts
  • apisnoop
    • I have access

Given the IAM role changes which had previously allowed access, I may now not have access to after the migration the two accounts: registry-k8s-io, k8s-infra-accounts. This meaning that others will need to delete some of the resources instead of me.

@BobyMCbobs
Copy link
Member

As verify-conformance is now running in GitHub Actions, several PRs will now be closed due to change in requirements.
https://github.com/cncf/k8s-conformance/actions/workflows/verify-conformance.yml

@BobyMCbobs
Copy link
Member

The branding for the conformance bot has been updated to reflect the conformance program and imminent Kubernetes ownership with:

  • name: Kubernetes Conformance bot
  • display image: certified Kubernetes

Screenshot 2024-05-29 at 10 36 39

@BobyMCbobs
Copy link
Member

verify-conformance has been turned off in the old EKS cluster, seen here: https://github.com/cncf-infra/prow-config/tree/master/infra/aws
The program is now running on a cron schedule in GitHub. The cluster will be removed in a few days to confirm stability.

@hh hh moved this from K8s Conformance to Sig K8s Infra in CNCF OKRs May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sig K8s Infra
Development

No branches or pull requests

2 participants