Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmarks #109

Open
mmaker opened this issue Jun 12, 2023 · 3 comments
Open

Adding benchmarks #109

mmaker opened this issue Jun 12, 2023 · 3 comments

Comments

@mmaker
Copy link

mmaker commented Jun 12, 2023

Hi! I am opening this issue to see if you'd be happy to receive contribution for some benchmarks. The zk-harness people already developed something https://github.com/zkCollective/zk-Harness/blob/feat/zkalc/circom/scripts/arithmetics.js#L28 but their quality is subpar. I'd be interesting in adding an "npm bench" that can be run to provide benchmarks for finite field arithmetic.

Incidentally this may also allow for comparison with other projects and uncovering significant optimisations! :)

@mmaker
Copy link
Author

mmaker commented Jun 19, 2023

We have added snarkjs in zkalc! Here's the source. I'd be happy to make a pull request and move them to this repo.
https://github.com/asn-d6/zkalc/blob/main/backend/iden3/curves.js

@phated
Copy link
Contributor

phated commented Jun 25, 2023

I'd love to review a PR if you want to put it together

@mmaker
Copy link
Author

mmaker commented Jun 27, 2023

@phated thank you so much! It's now available in #112 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants