Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_tests.sh broken with commit 87fd77f0d844fecfb6274477b563d43dab6ec334 #302

Open
deater opened this issue Jan 8, 2025 · 2 comments · May be fixed by #305
Open

run_tests.sh broken with commit 87fd77f0d844fecfb6274477b563d43dab6ec334 #302

deater opened this issue Jan 8, 2025 · 2 comments · May be fixed by #305

Comments

@deater
Copy link
Contributor

deater commented Jan 8, 2025

On a Debian Linux machine running current PAPI git ./run_tests.sh gives multiple errors of the type

./run_tests.sh: 142: [: true: unexpected operator
./run_tests.sh: 258: [: xperf_event: unexpected operator
etc

and only a small subset of the tests actually run. Backing things out to before 87fd77f and the full set of tests run as normal

@deater deater changed the title run_tests.sh broken with commit 95ef27b9b95fa9e1f3d520703337b1bf2f7453d2 run_tests.sh broken with commit 87fd77f0d844fecfb6274477b563d43dab6ec334 Jan 8, 2025
@deater
Copy link
Contributor Author

deater commented Jan 8, 2025

it looks like the updated script runs fine using "bash" as the shell, but Debian by default /bin/sh is "dash". So I guess the fix here is either change run_tests.sh to start with "#!/bin/bash" or else fix the recent changes to run_tests.sh to be strictly "sh" compatible

@Treece-Burgess
Copy link
Contributor

Hello Vince, I am able to recreate the unexpected operator errors on a machine running Debian 12. I do as well notice that the "Running Tests" section is completely skipped. I will look into it a bit more.

@Treece-Burgess Treece-Burgess linked a pull request Jan 14, 2025 that will close this issue
3 tasks
@Treece-Burgess Treece-Burgess linked a pull request Jan 14, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants