Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAPL not working on Intel i7-10700T #276

Open
hauensj1 opened this issue Nov 6, 2024 · 5 comments · May be fixed by #294
Open

RAPL not working on Intel i7-10700T #276

hauensj1 opened this issue Nov 6, 2024 · 5 comments · May be fixed by #294
Labels
component-rapl PRs and Issues related to the rapl component type-bug Issues discussing bugs or PRs fixing bugs

Comments

@hauensj1
Copy link

hauensj1 commented Nov 6, 2024

papi_component_avail reports that the RAPL component is not usable on Intel i7-10700T processor with an error of "CPU model not supported".

Digging into the code, it appears as though this Comet Lake chip returns a cpuid_model value of 165, which isn't matched by any of the switch cases in linux-rapl.c. Adding a case for 165 and having it fall through to the existing case 158 (Kabylake) code appears to (probably) work. At least, numbers are returned for the energy measurements now, and they look vaguely correct.

@Treece-Burgess
Copy link
Contributor

Treece-Burgess commented Nov 27, 2024

Hello @hauensj1, on the Intel I7-10700T can you send me the output for papi_component_avail in your-papi-installation-path/bin directory?

@Treece-Burgess
Copy link
Contributor

Hello @hauensj1, on the Intel I7-10700T can you send me the output for papi_component_avail in your-papi-installation-path/bin directory?

Following up with this.

@hauensj1
Copy link
Author

hauensj1 commented Dec 2, 2024

@Treece-Burgess Sorry for the delay. I was not back in the office until today.

I've attached the output from papi_component_avail when PAPI is build from the original code (in "before.txt") as well as its output when the additional switch case is added in linux-rapl.c as described in my original post. In the "before" case, it reports that the CPU model is not supported (based on not hitting any switch cases when comparing against hw_info->cpuid_model in linux-rapl.c).

This is output from PAPI 6.0.0.1, because that is the library I was using on the machine at this time, but the status is the same in the latest PAPI 7 release (at least, as of a few weeks ago, when I last checked): it reports that the CPU model is not supported unless modified.

before.txt
after.txt

@Treece-Burgess Treece-Burgess linked a pull request Dec 13, 2024 that will close this issue
3 tasks
@Treece-Burgess
Copy link
Contributor

Hello @hauensj1 thank you for sending that to me! I hope you are having a good holiday season.

I have created PR #294 which will add support for Intel Comet Lake S/H for the RAPL component. I do not have access as of now to a machine that has an Intel Comet Lake S/H for testing and we would like to test before merging.

Would you be able to checkout the PR and test the RAPL component with this addition? After building PAPI, testing would include:

  • Running the PAPI utilities specifically papi_component_avail, papi_native_avail, and papi_command_line
  • Running the RAPL tests in components/rapl/tests

Along with running the tests, if you could send the output for each that would be great!

@Treece-Burgess
Copy link
Contributor

Hello @hauensj1 thank you for sending that to me! I hope you are having a good holiday season.

I have created PR #294 which will add support for Intel Comet Lake S/H for the RAPL component. I do not have access as of now to a machine that has an Intel Comet Lake S/H for testing and we would like to test before merging.

Would you be able to checkout the PR and test the RAPL component with this addition? After building PAPI, testing would include:

* Running the PAPI utilities specifically `papi_component_avail`, `papi_native_avail`, and `papi_command_line`

* Running the RAPL tests in `components/rapl/tests`

Along with running the tests, if you could send the output for each that would be great!

@hauensj1 I just wanted to follow up with this.

@Treece-Burgess Treece-Burgess added component-rapl PRs and Issues related to the rapl component type-bug Issues discussing bugs or PRs fixing bugs labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-rapl PRs and Issues related to the rapl component type-bug Issues discussing bugs or PRs fixing bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants